Change button checkbox/radios to ignore hidden input fields #27802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
NB: I wasn't sure if I was supposed to do |
Member
|
Why not just exclude |
Contributor
Author
|
@XhmikosR, we could. It's just a matter of preference. I'm happy to change if desired. |
Contributor
Author
|
@XhmikosR, oh. I'm sorry. I was on mobile and for some reason it didn't show the "Member" tag. I'll go and change it. |
XhmikosR
reviewed
Dec 8, 2018
Contributor
Author
|
Oh. I left it because I wasn't sure if it was used elsewhere and forgot to check. I'll remove. Just pushed the change in the attribute selector. |
Allows for HTML like:
```html
<div class="btn-group-toggle" data-toggle="buttons">
<label class="btn btn-info">
<input name="checkbox" type="hidden" value="0">
<input id="cb" name="checkbox" type="checkbox" value="1" autocomplete="off"> Click Me
</label>
</div>
```
Fixes #27795
Contributor
Author
|
Done |
Johann-S
approved these changes
Dec 10, 2018
XhmikosR
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for HTML like:
Fixes #27795