-
-
Notifications
You must be signed in to change notification settings - Fork 79.2k
Remove now unnecessary -ms-viewport and -ms-overflow-style directives #27789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Edge/Mobile appears to have moved support for `-ms-viewport` behind a flag at some point, instead supporting meta viewport directives. Removing this altogether also fixes issues in IE11 on high-dpi displays - see #21780
|
I believe the only browser that really fully supported and needed the |
|
Also confirming that removing this stuff fixes the IE11/high-dpi bug (tested on my Surface Pro 2017 with IE11) and doesn't seem to have any adverse effect in Edge/Win10 desktop |
MartijnCuppens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the devices available to test this, but it looks like you did some solid research and I like to see these -ms-hacks removed
mdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, awesome! Do we mention anything about this in our docs that'd need updating?
|
So, just to confirm, none of these is needed for IE 11? |
no, and in fact removing these fixes problems in IE #21780 |
|
@mdo sorry, missed this question
no, at least doing a search across all the docs didn't have anything that jumped out at me... |
Removed leftover from #27789
Edge/Mobile appears to have moved support for
-ms-viewportbehind a flag at some point, instead supporting meta viewport directives (verified just now with an actual Nokia/Win10/Edge device).Removing this altogether also fixes issues in IE11 on high-dpi displays - see #21780
Closes #21780