Skip to content

Conversation

@patrickhlauke
Copy link
Member

Edge/Mobile appears to have moved support for -ms-viewport behind a flag at some point, instead supporting meta viewport directives (verified just now with an actual Nokia/Win10/Edge device).
Removing this altogether also fixes issues in IE11 on high-dpi displays - see #21780

Closes #21780

Edge/Mobile appears to have moved support for `-ms-viewport` behind a flag at some point, instead supporting meta viewport directives.
Removing this altogether also fixes issues in IE11 on high-dpi displays - see #21780
@patrickhlauke patrickhlauke requested a review from a team as a code owner December 6, 2018 02:09
@patrickhlauke
Copy link
Member Author

I believe the only browser that really fully supported and needed the -ms-viewport was IE11/Win8 Mobile. And that's now obsolete (in fairness, even Win10 Mobile isn't looking so hot in recent years)

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Dec 6, 2018

Also confirming that removing this stuff fixes the IE11/high-dpi bug (tested on my Surface Pro 2017 with IE11) and doesn't seem to have any adverse effect in Edge/Win10 desktop

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the devices available to test this, but it looks like you did some solid research and I like to see these -ms-hacks removed

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, awesome! Do we mention anything about this in our docs that'd need updating?

@XhmikosR
Copy link
Member

XhmikosR commented Dec 8, 2018

So, just to confirm, none of these is needed for IE 11?

@patrickhlauke
Copy link
Member Author

So, just to confirm, none of these is needed for IE 11?

no, and in fact removing these fixes problems in IE #21780

@XhmikosR XhmikosR merged commit f3fc973 into v4-dev Dec 12, 2018
@XhmikosR XhmikosR deleted the v4-dev-ie11hidpiscrollfix branch December 12, 2018 19:24
@mdo mdo mentioned this pull request Dec 12, 2018
@patrickhlauke
Copy link
Member Author

@mdo sorry, missed this question

Do we mention anything about this in our docs that'd need updating?

no, at least doing a search across all the docs didn't have anything that jumped out at me...

MartijnCuppens added a commit that referenced this pull request Apr 30, 2019
Removed leftover from #27789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants