Skip to content

Fix body scrolling issue when modal open #27698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johann-S merged 5 commits into from
Nov 23, 2018
Merged

Fix body scrolling issue when modal open #27698

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d29ef0
Add `.modal-open` class at the same time changing padding-right
ysds Nov 21, 2018
bd05f7d
Move outside of `if` statement
ysds Nov 21, 2018
b7d2c3c
Merge branch 'v4-dev' into patch-4
XhmikosR Nov 21, 2018
631a6e3
Merge branch 'v4-dev' into patch-4
XhmikosR Nov 22, 2018
f0734f1
Merge branch 'v4-dev' into patch-4
Johann-S Nov 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/src/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ class Modal {

this._adjustDialog()

$(document.body).addClass(ClassName.OPEN)
Copy link
Member

@Johann-S Johann-S Nov 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it works to move this line above this._adjustDialog() ? Because I'm not a big fan of adding that in _setScrollbar method because it's not the purpose of this method

Copy link
Contributor Author

@ysds ysds Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but didn't work. We need to reduce the number of renderings.


this._setEscapeEvent()
this._setResizeEvent()

Expand Down Expand Up @@ -466,6 +464,8 @@ class Modal {
.data('padding-right', actualPadding)
.css('padding-right', `${parseFloat(calculatedPadding) + this._scrollbarWidth}px`)
}

$(document.body).addClass(ClassName.OPEN)
}

_resetScrollbar() {
Expand Down