Adds a note about limitations on content being larger than the image #27321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age. In the event that the content is larger than the image, the content will continue to be displayed outside the image itself. There are some workarounds but they apply only to browsers that support this option and IE11 is not one of them.
Member
|
There's a typo in the filename of the new file you added. Also, why do we need this to be a new include if it's used only once? |
Instead of using an external source since this is only a one time note it is safe to be placed within the document itself.
Deleting external file since it is not needed, the copy of this file will be added directly to card.md.
Contributor
Author
|
@XhmikosR Thanks for the feedback, at first I thought I was following best practices by adding the data to an external file but it seems like that is not necessary. |
Member
|
@MartijnCuppens: LGTY? |
Member
|
LGTM: |
XhmikosR
approved these changes
Oct 17, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that the content is larger than the image, the content will continue to be displayed outside the image itself. There are some workarounds but they apply only to browsers that support this option and IE11 is not one of them.
This pull request should fulfill the need in issue #27189