Skip to content

Move transparent background to .btn and remove background-image #27003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdo merged 5 commits into from
Sep 2, 2018
Merged

Move transparent background to .btn and remove background-image #27003

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86a70c6
Move transparent background to .btn and remove background-image
MartijnCuppens Jul 31, 2018
43032ea
Merge branch 'v4-dev' into btn
XhmikosR Aug 2, 2018
537cbae
Merge branch 'v4-dev' into btn
MartijnCuppens Aug 2, 2018
fe363ed
Set .btn base color
MartijnCuppens Aug 2, 2018
9a7591e
Merge branch 'v4-dev' into btn
XhmikosR Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scss/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,19 @@
.btn {
display: inline-block;
font-weight: $btn-font-weight;
color: $body-color;
text-align: center;
white-space: nowrap;
vertical-align: middle;
user-select: none;
background-color: transparent;
border: $btn-border-width solid transparent;
@include button-size($btn-padding-y, $btn-padding-x, $font-size-base, $btn-line-height, $btn-border-radius);
@include transition($btn-transition);

// Share hover and focus styles
@include hover-focus {
color: $body-color;
text-decoration: none;
}

Expand Down
2 changes: 0 additions & 2 deletions scss/mixins/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@

@mixin button-outline-variant($color, $color-hover: color-yiq($color), $active-background: $color, $active-border: $color) {
color: $color;
background-color: transparent;
background-image: none;
Copy link
Member

@mdo mdo Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the background-image: none was for overriding some browser defaults on the button. I can't recall which browser or version, but I recall having to set this in order for custom backgrounds to work properly. Looking around, seems fine now.

Copy link
Member

@mdo mdo Aug 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes:

bootstrap/less/buttons.less

Line 17 in 2c2ac33

background-image: none; // Reset unusual Firefox-on-Android default style; see https://github.com/necolas/normalize.css/issues/214

And it looks like it was then removed in Android Firefox, so safe to ship I think. necolas/normalize.css#214 (comment)

Copy link
Member

@XhmikosR XhmikosR Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but do we support such old versions anymore? I too remember this issue but it was very old.

Copy link
Member Author

@MartijnCuppens MartijnCuppens Aug 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .btn elements don't have a background-image either, that's why I assumed it was save to remove this.

border-color: $color;

&:hover {
Expand Down