Skip to content

Simplify custom file inner height for generated browse button #26416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdo merged 1 commit into from
Apr 30, 2018
Merged

Simplify custom file inner height for generated browse button #26416

mdo merged 1 commit into from
Apr 30, 2018

Conversation

@mdo
Copy link
Member

@mdo mdo commented Apr 29, 2018

Closes #25724 which had us doing more unnecessary math:

-  height: calc(calc(2.25rem + 2px) - 1px * 2);
+  height: calc(2.25rem + 2px - 1px * 2);

By instead extending the $input-height-inner variable:

-  height: calc(calc(2.25rem + 2px) - 1px * 2);
+  height: 2.25rem;

Fixes #25717.

/cc @MartijnCuppens

@mdo mdo merged commit 139e892 into v4-dev Apr 30, 2018
@mdo mdo deleted the custom-file-height-inner branch April 30, 2018 00:02
@mdo mdo mentioned this pull request Apr 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

css v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdo