Skip to content

Clarify the necessary data-target/href attribute for carousel controls #25690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XhmikosR merged 3 commits into from
Mar 13, 2018
Merged

Clarify the necessary data-target/href attribute for carousel controls #25690

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde6969
Clarify the necessary `data-target`/`href` attribute for carousel con…
balbuf Feb 22, 2018
9b26e49
Merge branch 'v4-dev' into patch-1
balbuf Mar 8, 2018
ec166b6
Merge branch 'v4-dev' into patch-1
XhmikosR Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/4.0/components/carousel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Lastly, if you're building our JavaScript from source, it [requires `util.js`]({

Carousels don't automatically normalize slide dimensions. As such, you may need to use additional utilities or custom styles to appropriately size content. While carousels support previous/next controls and indicators, they're not explicitly required. Add and customize as you see fit.

**The `.active` class needs to be added to one of the slides** otherwise the carousel will not be visible. Also be sure to set a unique id on the `.carousel` for optional controls, especially if you're using multiple carousels on a single page.
**The `.active` class needs to be added to one of the slides** otherwise the carousel will not be visible. Also be sure to set a unique id on the `.carousel` for optional controls, especially if you're using multiple carousels on a single page. Control and indicator elements must have a `data-target` attribute (or `href` for links) that matches the id of the `.carousel` element.

### Slides only

Expand Down