Fix tab.js Problem

[dercodercom]

I'm using Tab.js with remove function and get an error "TypeError: container is undefined [more info]", with this check the error is fixed.

Fixes: #27522

[XhmikosR]

@dercodercom: can you share a codepen demonstrating this issue? The fix does make sense in general, but we need to see when it actually fails.

[Johann-S]

agree with @XhmikosR

[dercodercom]

@XhmikosR the test link: https://codepen.io/anon/pen/mpYPaQ if you close a non-selected tab, the error comes.

[Johann-S]

weird use case 🤔

Anyway, we need a unit test

[XhmikosR]

@dercodercom: can you add a unit test as per @Johann-S's comment above?

[twbs-closer]

Hey there!

We're automatically closing this issue since the original poster (or another commenter) hasn't yet responded to the question or request made to them 14 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.

Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

(Please note that this is an automated comment.)

[XhmikosR]

@Johann-S: maybe we should reconsider for this?

[Johann-S]

ping @dercodercom

[twbs-closer]

Hey there!

We're automatically closing this issue since the original poster (or another commenter) hasn't yet responded to the question or request made to them 14 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.

Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

(Please note that this is an automated comment.)

[XhmikosR]

@Johann-S: do you still plan to add a test case for this? If not let's close it.

[Johann-S]

Yep we should add a unit test here, if @dercodercom cannot I'll try to do that

[XhmikosR]

He hasn't responded for a long time so if you could tackle this that'd be awesome :)

[Johann-S]

@XhmikosR the job is done here, if you want to take a look 😉