Skip to content

Consistently use :disabled rather than [disabled] selector #25317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Consistently use :disabled rather than [disabled] selector #25317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scss/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
}

// Opinionated: add "hand" cursor to non-disabled .btn elements
&:not([disabled]):not(.disabled) {
&:not(:disabled):not(.disabled) {
cursor: pointer;
}

&:not([disabled]):not(.disabled):active,
&:not([disabled]):not(.disabled).active {
&:not(:disabled):not(.disabled):active,
&:not(:disabled):not(.disabled).active {
background-image: none;
@include box-shadow($btn-active-box-shadow);

Expand All @@ -51,7 +51,7 @@

// Future-proof disabling of clicks on `<a>` elements
a.btn.disabled,
fieldset[disabled] a.btn {
fieldset:disabled a.btn {
pointer-events: none;
}

Expand Down
2 changes: 1 addition & 1 deletion scss/_close.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}

// Opinionated: add "hand" cursor to non-disabled .close elements
&:not([disabled]):not(.disabled) {
&:not(:disabled):not(.disabled) {
cursor: pointer;
}
}
Expand Down
2 changes: 1 addition & 1 deletion scss/_navbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
}

// Opinionated: add "hand" cursor to non-disabled .navbar-toggler elements
&:not([disabled]):not(.disabled) {
&:not(:disabled):not(.disabled) {
cursor: pointer;
}
}
Expand Down
2 changes: 1 addition & 1 deletion scss/_pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
}

// Opinionated: add "hand" cursor to non-disabled .page-link elements
&:not([disabled]):not(.disabled) {
&:not(:disabled):not(.disabled) {
cursor: pointer;
}
}
Expand Down
8 changes: 4 additions & 4 deletions scss/mixins/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
border-color: $border;
}

&:not([disabled]):not(.disabled):active,
&:not([disabled]):not(.disabled).active,
&:not(:disabled):not(.disabled):active,
&:not(:disabled):not(.disabled).active,
.show > &.dropdown-toggle {
color: color-yiq($active-background);
background-color: $active-background;
Expand Down Expand Up @@ -77,8 +77,8 @@
background-color: transparent;
}

&:not([disabled]):not(.disabled):active,
&:not([disabled]):not(.disabled).active,
&:not(:disabled):not(.disabled):active,
&:not(:disabled):not(.disabled).active,
.show > &.dropdown-toggle {
color: color-yiq($active-background);
background-color: $active-background;
Expand Down