Improve album example on mobile #25253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the interest of using Bootstrap's own grid system for the cards in this example, I removed both the float and width properties from the .card class.
- Adds .col-md-4 to every card in an effort to improve user experience on mobile devices - Refactors footer section to use Bootstrap's own grid system, simultaneously improving user experience on mobile devices
Member
|
Haven't looked at the code changes here, but nearly all the examples are getting updated and I'm adding new ones in #24898. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last night, I was looking through Bootstrap's documentation on my phone, and I noticed that the album example looked rather odd. My first thought was that maybe the examples are not meant to be optimized for mobile. After looking at the other examples, which look just as good on mobile, I concluded otherwise.
In these commits, I did the following:
In my opinion, the end result is a much better experience on mobile. The only thing that sticks out now is that the buttons at the top hug each other on mobile. Anyways, I figured this is a decent start.