Fixed color for disabled buttons #25167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
approved these changes
Jan 4, 2018
Collaborator
andresgalante
left a comment
andresgalante
left a comment
There was a problem hiding this comment.
Hi @wolfgangGoedel thanks for the contribution.
To test this PR, increase the darken function for hover background on the button mixin to for example 50% and try to hover over a disabled light btn.
mdo
approved these changes
Jan 12, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing reset for disabled button color could cause hover effect on disabled buttons when hover color changed i.e. from light to dark