Expand keyboard advice for tooltips, clarify what manual trigger does in table
#25163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
reviewed
Jan 2, 2018
docs/4.0/components/tooltips.md
Outdated
| ### Disabled elements | ||
|
|
||
| Elements with the `disabled` attribute aren't interactive, meaning users cannot hover or click them to trigger a tooltip (or popover). As a workaround, you'll want to trigger the tooltip from a wrapper `<div>` or `<span>` and override the `pointer-events` on the disabled element. | ||
| Elements with the `disabled` attribute aren't interactive, meaning users cannot focus, hover or click them to trigger a tooltip (or popover). As a workaround, you'll want to trigger the tooltip from a wrapper `<div>` or `<span>`, ideally made keyboard-focusable using `tabindex="0"`, and override the `pointer-events` on the disabled element. |
Member
There was a problem hiding this comment.
Oxford comma in first sentence, please—focus, hover, or click.
docs/4.0/components/tooltips.md
Outdated
| <p>The tooltip's <code>title</code> will be injected into the <code>.tooltip-inner</code>.</p> | ||
| <p><code>.arrow</code> will become the tooltip's arrow.</p> | ||
| <p>The outermost wrapper element should have the <code>.tooltip</code> class.</p> | ||
| <p>The outermost wrapper element should have the <code>.tooltip</code> class, as well as a <code>role="tooltip"</code>.</p> |
Member
There was a problem hiding this comment.
This can be more succinct:
The outermost wrapper element should have the <code>.tooltip</code> class and <code>role="tooltip"</code>
Member
|
I think we should update |
Member
Author
|
@Johann-S good point, will tackle |
Member
Author
|
@mdo changes made. good to go? |
Member
Author
|
@Johann-S or @andresgalante ... mind giving this a green light if you feel it's ok? |
Member
Author
|
cool thanks @Johann-S |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.