Skip to content

Only validate required form controls #24904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Only validate required form controls #24904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aa003b
Only apply validation styles to required form controls
mdo Nov 28, 2017
9488808
add mention of required attr to docs
mdo Nov 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/4.0/components/forms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ We **highly recommend** custom validation styles as native browser defaults are

Here's how form validation works with Bootstrap:

- HTML form validation is applied via CSS's two pseudo-classes, `:invalid` and `:valid`. It applies to `<input>`, `<select>`, and `<textarea>` elements.
- HTML form validation is applied via CSS's two pseudo-classes, `:invalid` and `:valid`. It applies to `<input>`, `<select>`, and `<textarea>` elements with the `required` attribute.
- Bootstrap scopes the `:invalid` and `:valid` styles to parent `.was-validated` class, usually applied to the `<form>`. Otherwise, any required field without a value shows up as invalid on page load. This way, you may choose when to activate them (typically after form submission is attempted).
- As a fallback, `.is-invalid` and `.is-valid` classes may be used instead of the pseudo-classes for [server side validation](#server-side). They do not require a `.was-validated` parent class.
- Due to constraints in how CSS works, we cannot (at present) apply styles to a `<label>` that comes before a form control in the DOM without the help of custom JavaScript.
Expand Down
8 changes: 4 additions & 4 deletions scss/mixins/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
border-radius: .2rem;
}

.form-control,
.custom-select {
.form-control:required,
.custom-select:required {
.was-validated &:#{$state},
&.is-#{$state} {
border-color: $color;
Expand All @@ -70,7 +70,7 @@


// TODO: redo check markup lol crap
.form-check-input {
.form-check-input:required {
.was-validated &:#{$state},
&.is-#{$state} {
+ .form-check-label {
Expand All @@ -80,7 +80,7 @@
}

// custom radios and checks
.custom-control-input {
.custom-control-input:required {
.was-validated &:#{$state},
&.is-#{$state} {
~ .custom-control-indicator {
Expand Down