Skip to content

adds hover state to the button element for background color utilities #24813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 23, 2017
Merged

adds hover state to the button element for background color utilities #24813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2895d78
adds a hover state to the button element on the backrgound color utit…
andresgalante Nov 17, 2017
134dbfa
Merge branch 'v4-dev' into v4-dev-andres-adds-hover-to-button
XhmikosR Nov 30, 2017
53be05e
Merge branch 'v4-dev' into v4-dev-andres-adds-hover-to-button
mdo Dec 23, 2017
445150e
Adjust z-index to fix hover/focus overlaps
mdo Dec 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scss/_list-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
}

@include hover-focus {
z-index: 1; // Place hover/active items above their siblings for proper border styling
text-decoration: none;
}

Expand All @@ -70,7 +71,7 @@

// Include both here for `<a>`s and `<button>`s
&.active {
z-index: 1; // Place active items above their siblings for proper border styling
z-index: 2; // Place active items above their siblings for proper border styling
color: $list-group-active-color;
background-color: $list-group-active-bg;
border-color: $list-group-active-border-color;
Expand Down
3 changes: 2 additions & 1 deletion scss/mixins/_background-variant.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#{$parent} {
background-color: $color !important;
}
a#{$parent} {
a#{$parent},
button#{$parent} {
@include hover-focus {
background-color: darken($color, 10%) !important;
}
Expand Down