Skip to content

Fix nested cards on card group #24766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2017
Merged

Fix nested cards on card group #24766

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a9956c
fixes nested cards on card group
andresgalante Nov 13, 2017
04b3c22
Merge branch 'v4-dev' into v4-dev-andres-fix-nested-card-group
XhmikosR Nov 16, 2017
800b161
Merge branch 'v4-dev' into v4-dev-andres-fix-nested-card-group
XhmikosR Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions scss/_card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,17 @@
display: flex;
flex-direction: column;

.card {
// The child selector allows nested `.card` within `.card-group`
// to display properly.
> .card {
margin-bottom: $card-group-margin;
}

@include media-breakpoint-up(sm) {
flex-flow: row wrap;

.card {
// The child selector allows nested `.card` within `.card-group`
// to display properly.
> .card {
// Flexbugs #4: https://github.com/philipwalton/flexbugs#4-flex-shorthand-declarations-with-unitless-flex-basis-values-are-ignored
flex: 1 0 0%;
margin-bottom: 0;
Expand Down