Skip to content

Update _screen-reader.scss #22154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdo merged 5 commits into from
Mar 19, 2017
Merged

Update _screen-reader.scss #22154

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c144dc
Update _screen-reader.scss
ffoodd Mar 10, 2017
df8d86b
Reorder declarations
ffoodd Mar 10, 2017
f836055
Trailing spaces
ffoodd Mar 10, 2017
2ff67fe
Last trailing space?
ffoodd Mar 10, 2017
ca8320a
Remove margin: -1px
ffoodd Mar 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scss/mixins/_screen-reader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Only display content to screen readers
//
// See: http://a11yproject.com/posts/how-to-hide-content
// See: http://hugogiraudel.com/2016/10/13/css-hide-and-seek/

@mixin sr-only {
position: absolute;
Expand All @@ -9,7 +10,9 @@
padding: 0;
margin: -1px;
Copy link
Member

@mdo mdo Mar 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop the margin: -1px? I don't see it in Hugo's post and I know we had an issue with it on GitHub causing a horizontal scrollbar with that.

overflow: hidden;
white-space: nowrap;
clip: rect(0,0,0,0);
clip-path: inset(50%);
border: 0;
}

Expand All @@ -27,6 +30,8 @@
height: auto;
margin: 0;
overflow: visible;
white-space: normal;
Copy link

@houndci-bot houndci-bot Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered position, width, height, margin, overflow, clip, white-space, clip-path

clip: auto;
clip-path: none;
}
}