4063: Make dialog size more stable #4066
Conversation
| <com.ortiz.touchview.TouchImageView | ||
| android:id="@+id/imageDescriptionView" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="0dp" |
There was a problem hiding this comment.
Can layout height be set to match_parent here so you don't have to set it in whatever you are doing in the onStart block?
There was a problem hiding this comment.
This is the image view (with layout_weight=1).
The things in the onStart influence the window/dialog. Normally an (alert) dialog implicitly has something like "wrap_content" that is overwritten there.
connyduck
left a comment
connyduck
left a comment
There was a problem hiding this comment.
Definitely better than before.
I wonder if the dialog would be better if the image had a bit of margin around it. Looks a bit weird when it is glued to the side like that
|
|
||
| override fun onLoadFailed(errorDrawable: Drawable?) { | ||
| super.onLoadFailed(errorDrawable) | ||
| imageView.hide() |
There was a problem hiding this comment.
I think instead of just assuming it is an audio file when loading fails I'd rather pass an explicit flag. The flag could also be used to display a different hint that makes more sense for audio files.
There was a problem hiding this comment.
I was wondering (and didn't quickly find) how to find the type of the media thing.
Because always putting it in Glide says that the code expects an image there - which it probably shouldn't.
That was a concious choice in the previous issue here (improving that dialog 5 months ago): Use as much space for the dialog and in it for the image as is possible/sensible. |
Ok let's leave it then. The dialog is now gigantic on tablets, any possibility it could have like a max size? Or at least show the image larger? 
|
True. However that is not new here and also affects other dialogs (e. g. "accounts in list"). (Generally tablets would appreciate some love. :-)
|
4 participants
Fixes: #4063
Switching from an AlertDialog to only a DialogFragment.
I didn't get the AlertDialog to be sized correctly.
It also opens now directly with the right (full screen) size. When the imageView fails to load (i.e. with an audio file) it will be hidden.
This changes the button layout somewhat.
One observation: The placeholder text "... visually impaired..." is not quite right as a description for an audio file is not intended for the visually impaired. But I couldn't think of a better text just yet.