Migrate delete room api to v2#202
Merged
turt2live merged 2 commits intoturt2live:masterfrom Mar 18, 2022
Merged
Conversation
turt2live
approved these changes
Mar 18, 2022
Owner
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Thanks! Apologies for the delay on reviewing this - was hoping to get other changes through at the same time, but ultimately it's not worth waiting at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the delete room admin api to the new v2 as described here: https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#version-2-new-version
This change is necessary because v1 has already been removed: https://github.com/matrix-org/synapse/blob/develop/CHANGES.md#synapse-1470rc1-2021-11-09
matrix-org/synapse#11213