api: fix race for a stopClient channel #625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demget
changed the title
DmytroSolodukhin
approved these changes
Dec 25, 2023
davseby
reviewed
Dec 28, 2023
|
|
||
| // do nothing if called twice | ||
| if b.stopClient != nil { | ||
| if b.getChanStopClient() != nil { |
Contributor
There was a problem hiding this comment.
We're still racing here, it would be better to encapsulate nil checking and creating into a one mutex call. Same with the stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Before starting the bot I do a setCommands and its goroutine [
which reads channel variable] does not have time to complete before the start method [which writes to channel variable].Previous read at 0x00c0015a6628 by goroutine 106:
https://github.com/tucnak/telebot/blob/v3/api.go#L39
Write at 0x00c0015a6628 by main goroutine:
https://github.com/tucnak/telebot/blob/v3/bot.go#L205
Decision
Use mutex for use channel
stopClient.Also added changes from https://github.com/caalberts/telebot to work with testnet.