Skip to content

[Mellanox] Add CMIS revision check to determine software control support#36

Closed
tshalvi wants to merge 1 commit intomasterfrom
master_add_cmis_revision_validation_for_sw_controlled_ports
Closed

[Mellanox] Add CMIS revision check to determine software control support#36
tshalvi wants to merge 1 commit intomasterfrom
master_add_cmis_revision_validation_for_sw_controlled_ports

Conversation

@tshalvi
Copy link
Owner

@tshalvi tshalvi commented Jun 30, 2025

Why I did it

To ensure software control is only enabled for CMIS modules that comply with revision 5.2 or higher, as required by design. This avoids applying software control to modules that do not support it.

Work item tracking
  • Microsoft ADO (number only):

How I did it

  • Added a new method is_cmis_rev_supported_for_software_control() to validate the CMIS revision.
  • Updated the logic in is_supported_for_software_control() to include CMIS revision check for both flat and non-flat memory modules.

How to verify it

Verify that for CMIS modules, software control is applied only to ports with a CMIS revision of 5.2 or higher. This applies to both active and passive modules.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@tshalvi
Copy link
Owner Author

tshalvi commented Jul 6, 2025

Need to revert this change as Verification needs it enabled on Bagheeras until they get fully populated Innolights, otherwise - they lose coverage

@tshalvi tshalvi closed this Jul 6, 2025
tshalvi pushed a commit that referenced this pull request Aug 25, 2025
…tomatically (sonic-net#877)

#### Why I did it
src/sonic-linux-kernel
```
* cdbd77b - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (#36) (21 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
tshalvi pushed a commit that referenced this pull request Aug 25, 2025
…omatically (sonic-net#900)

#### Why I did it
src/sonic-swss-common
```
* b700027 - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (#36) (20 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
tshalvi pushed a commit that referenced this pull request Aug 25, 2025
…D automatically (sonic-net#964)

#### Why I did it
src/sonic-sairedis
```
* 80da97d - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #36 from Pterosaur/update_sai (21 hours ago) [Ze Gan]
```
#### How I did it
#### How to verify it
#### Description for the changelog
tshalvi pushed a commit that referenced this pull request Aug 25, 2025
…D automatically (sonic-net#969)

#### Why I did it
src/sonic-sairedis
```
* 80da97d - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #36 from Pterosaur/update_sai (2 days ago) [Ze Gan]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants