Skip to content

[Mellanox] Validate module presence before accessing its EEPROM #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tshalvi wants to merge 2 commits into from
Closed

[Mellanox] Validate module presence before accessing its EEPROM #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
347adda
Refactor to validate module presence before accessing its EEPROM
tshalvi May 27, 2024
60c1fd3
Changed log level from warning to info
tshalvi May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions platform/mellanox/mlnx-platform-api/sonic_platform/sfp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,11 @@ def _read_eeprom(self, offset, num_bytes, log_on_error=True):
Returns:
bytearray: the content of EEPROM
"""
presence_sysfs = f'/sys/module/sx_core/asic0/module{self.sdk_index}/hw_present' if self.is_sw_control() else f'/sys/module/sx_core/asic0/module{self.sdk_index}/present'
if utils.read_int_from_file(presence_sysfs) != 1:
Copy link
Copy Markdown

@dprital dprital May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!=1 Means no module is connected ? If so, why to add Warning to LOG ?

Copy link
Copy Markdown

@Junchao-Mellanox Junchao-Mellanox May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Info level is good enough.

Copy link
Copy Markdown
Owner Author

@tshalvi tshalvi May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

logger.log_info(f'Failed attempt to read EEPROM for sfp={self.sdk_index}: No module connected')
return None

result = bytearray(0)
while num_bytes > 0:
_, page, page_offset = self._get_page_and_page_offset(offset)
Expand Down