Initialize SPICE parser library structure#1
Conversation
seveibar
left a comment
There was a problem hiding this comment.
i don't think this is correctly bootstrapped- i would not merge this.
You should start with a lot of examples. Don't let AI generate the examples.
Make sure the classes are extremely specific, SpiceElement is a really bad class, likewise with SpiceDirective. See kicadts and our other ts modules
The quality enforcement for these ts parsers must be extremely high!!!
seveibar
left a comment
There was a problem hiding this comment.
ahh can't do it. This isn't right
seveibar
left a comment
There was a problem hiding this comment.
tokenizer needs to live separately (an equivalent of Sexpr)
|
A bit scattered, but here's a video review: https://cleanshot.com/share/gF8pp21z Major takeaway, we need a tokenizer- without a tokenizer you can't really build the classes properly- this is a big learning from kicadts overall i'm pretty happy with the rate of progress- but if we merge now i think we would not have a good enough foundation to go "all the way"- the tokenizer and the static methods for turning tokenized objects into classes is critical You also don't have the extremely important/ergonomic registration system! Look at KicadTs's registration system- it is really great
|
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |

Scaffolds spicets following the tscircuit parser-library guide with a tokenized parse pipeline, registered class-based SPICE card model, root netlist/library classes, parse functions, deterministic serialization, unknown-card preservation, public exports, README API docs, and focused unit/round-trip fixture tests.