Add repro for dense parallel header-to-IC schematic routing#450
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
changed the title
There was a problem hiding this comment.
Pull request overview
Adds a new routing repro case (example40) to exercise dense parallel header-to-IC direct connections in the schematic trace solver, along with a pipeline debugger page and a snapshot-based regression test.
Changes:
- Added
tests/assets/example40.jsondefining a dense set of parallel direct connections fromJ2toU1. - Added
tests/examples/example40.test.tsand correspondingtests/examples/__snapshots__/example40.snap.svgsnapshot to lock in solver output for this case. - Added
site/examples/example40.page.tsxto load the repro into the Pipeline Debugger UI.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/examples/example40.test.ts | Adds a snapshot test that runs SchematicTracePipelineSolver on example40.json. |
| tests/examples/snapshots/example40.snap.svg | Stores the expected rendered SVG output for the new repro case. |
| tests/assets/example40.json | Introduces the new repro input problem (chips/pins + direct connections). |
| site/examples/example40.page.tsx | Adds a debugger page to visualize/step through the example40 pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sang-it
approved these changes
May 28, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
example40, a schematic trace solver repro covering a dense set of parallel direct connections from a 9-pinJ2header toU1. The case exercises routing behavior where adjacent nets must cross between closely spaced left-side pins and mixed/staggered right-side pins.Changes
tests/assets/example40.jsonsite/examples/example40.page.tsxfor the pipeline debuggertests/examples/example40.test.tsexample40Validation
bun test tests/examples/example40.test.tsbun run format:check tests/assets/example40.json site/examples/example40.page.tsx tests/examples/example40.test.ts