Add dash length and gap props for schematic line and path#684
Merged
rushabhcodes merged 1 commit intoMay 31, 2026
Merged
Conversation
seveibar
approved these changes
May 31, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds
dashLengthanddashGapsupport to<schematicline />and<schematicpath />, matching the existingdash_lengthanddash_gapfields incircuit-json.Why
circuit-jsonalready models dash length and gap for schematic lines and paths, but@tscircuit/propsdid not expose corresponding JSX props. This lets consumers configure schematic dash patterns through props instead of being limited to the default dashed behavior.Validation
bun test tests/schematic-line.test.ts tests/schematic-path.test.tsbunx tsc --noEmitbun scripts/generate-component-types.tsbun scripts/generate-manual-edits-docs.tsbun scripts/generate-readme-docs.tsbun scripts/generate-props-overview.tsbun run format:check lib/components/schematic-line.ts lib/components/schematic-path.ts tests/schematic-line.test.ts tests/schematic-path.test.ts