Skip to content

Add dash length and gap props for schematic line and path#684

Merged
rushabhcodes merged 1 commit into
tscircuit:mainfrom
rushabhcodes:add-schematic-dash-length-gap-props
May 31, 2026
Merged

Add dash length and gap props for schematic line and path#684
rushabhcodes merged 1 commit into
tscircuit:mainfrom
rushabhcodes:add-schematic-dash-length-gap-props

Conversation

@rushabhcodes
Copy link
Copy Markdown
Contributor

What changed

Adds dashLength and dashGap support to <schematicline /> and <schematicpath />, matching the existing dash_length and dash_gap fields in circuit-json.

Why

circuit-json already models dash length and gap for schematic lines and paths, but @tscircuit/props did not expose corresponding JSX props. This lets consumers configure schematic dash patterns through props instead of being limited to the default dashed behavior.

Validation

  • bun test tests/schematic-line.test.ts tests/schematic-path.test.ts
  • bunx tsc --noEmit
  • bun scripts/generate-component-types.ts
  • bun scripts/generate-manual-edits-docs.ts
  • bun scripts/generate-readme-docs.ts
  • bun scripts/generate-props-overview.ts
  • bun run format:check lib/components/schematic-line.ts lib/components/schematic-path.ts tests/schematic-line.test.ts tests/schematic-path.test.ts

@rushabhcodes rushabhcodes marked this pull request as ready for review May 31, 2026 10:55
Copilot AI review requested due to automatic review settings May 31, 2026 10:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rushabhcodes rushabhcodes merged commit e45677d into tscircuit:main May 31, 2026
6 checks passed
@rushabhcodes rushabhcodes deleted the add-schematic-dash-length-gap-props branch May 31, 2026 16:16
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants