Add spicemodel support to chip props and spicemodel component#682
Merged
Conversation
seveibar
reviewed
May 30, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Lets just start with spicemodel, check the casing plz
Contributor
|
I dont know if introducing the spice namespace or spice elements is a good idea yet. It discourages prople from changing chip to opamp for example- i do think we will eventually have it but it is not related to our main objective for ti |
ShiboSoftwareDev
changed the title
seveibar
reviewed
May 30, 2026
seveibar
approved these changes
May 30, 2026
Contributor
|
@ShiboSoftwareDev i dont think the direction of pin mapping is clear, |
Contributor
Author
|
how can we fix that? |
Contributor
|
How can we improve that… |
Contributor
Author
|
spicePinMapping? |
Contributor
|
That is better… spicePinMapping is workable |
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.