Add support showSolderMask option for CircuitPreview and capacitive touch sensor #312
+74
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
Nov 5, 2025
| if (showSolderMask) { | ||
| return createSvgUrl(fsMapOrCode, "pcb", { showSolderMask: true }) | ||
| } | ||
| return createSvgUrl(fsMapOrCode, "pcb") |
Contributor
There was a problem hiding this comment.
You can simplify this by allowing showSolderMask to be undefined
Contributor
|
3d view is messed up, it is a simple fix in circuit json to gltf, you just need to add showSolderMask to it’s internal call to circuit-to-svg! Nice work!!! also, traditionally the schematic representation should have all the pins on one side, you can use schPinArrangement 
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix tscircuit/tscircuit#786
/claim tscircuit/tscircuit#786