Add custom SPICE subcircuit models via <spicemodel />#2364
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
May 31, 2026
seveibar
reviewed
May 31, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
This would be a normal component feature, not just for chips fwiw
you didnt create a new class (all other elements have classes?)
I dont understand why youre parsing the subcircuit to get the name- it doesnt seem necessary?
ShiboSoftwareDev
changed the title
seveibar
approved these changes
May 31, 2026
seveibar
approved these changes
May 31, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Surprised this works, i think usually children elements need special handling to properly work w the render cycle
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Spicemodel component that can be passed through spiceModel={
<spicemodel />} on normalcomponents to emit simulation_spice_subcircuit circuit-json. The implementation uses spicets
to parse .subckt definitions, maps SPICE pins to component ports through spicePinMapping or
matching pin names.