Skip to content

Fix breakout point SRJ construction to route through boundary points#2360

Merged
MustafaMulla29 merged 6 commits into
mainfrom
fix/srj
May 31, 2026
Merged

Fix breakout point SRJ construction to route through boundary points#2360
MustafaMulla29 merged 6 commits into
mainfrom
fix/srj

Conversation

@MustafaMulla29
Copy link
Copy Markdown
Contributor

@MustafaMulla29 MustafaMulla29 commented May 30, 2026

  • Filter directTraceConnections by subcircuit_id so internal traces routed inside a breakout are not duplicated in the parent's SRJ
  • Add breakout point coordinates as additional points in pointsToConnect for cross-boundary traces, ensuring the autorouter routes through the boundary crossing
  • Skip breakout points that are already handled by cross-boundary traces; only create direct [port, bp] connections for manual breakout points without a cross-boundary trace

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment May 31, 2026 4:12pm

Request Review

@MustafaMulla29
Copy link
Copy Markdown
Contributor Author

@seveibar tried to solve it by following your suggestions, but i think there are still issues.

@MustafaMulla29 MustafaMulla29 requested a review from seveibar May 30, 2026 14:54
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is correct, breakout points should be used but their matched point should be excluded, this will fix traces not using the breakout point

@MustafaMulla29
Copy link
Copy Markdown
Contributor Author

@seveibar something or the other is getting regressed if I try to fix it

Comment thread lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts Outdated
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@seveibar
Copy link
Copy Markdown
Contributor

@MustafaMulla29 this is looking a lot better

Comment thread lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is happening here with the trace going at the top

@MustafaMulla29 MustafaMulla29 requested a review from seveibar May 31, 2026 16:13
@MustafaMulla29 MustafaMulla29 merged commit fa21c0d into main May 31, 2026
12 checks passed
@MustafaMulla29 MustafaMulla29 deleted the fix/srj branch May 31, 2026 16:50
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants