Fix breakout point SRJ construction to route through boundary points#2360
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@seveibar tried to solve it by following your suggestions, but i think there are still issues. |
MustafaMulla29
commented
May 30, 2026
MustafaMulla29
commented
May 30, 2026
seveibar
reviewed
May 30, 2026
Contributor
seveibar
left a comment
There was a problem hiding this comment.
I don’t think this is correct, breakout points should be used but their matched point should be excluded, this will fix traces not using the breakout point
Contributor
Author
|
@seveibar something or the other is getting regressed if I try to fix it |
seveibar
reviewed
May 31, 2026
Contributor
|
@MustafaMulla29 this is looking a lot better |
seveibar
reviewed
May 31, 2026
MustafaMulla29
commented
May 31, 2026
Contributor
Author
There was a problem hiding this comment.
Not sure what is happening here with the trace going at the top
seveibar
approved these changes
May 31, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.