fix: When <chip /> and <smtpad /> both have layer as bottom then the footprint should render it on the bottom layer#2359
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
force-pushed
the
fix-bottom-laer
branch
from
a5b92ac to
3edfbdd
Compare
imrishabh18
changed the title
<chip /> and <smtpad /> both have layer as bottom then the footprint should render it on the bottom layer
seveibar
approved these changes
May 30, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
I get the idea here- i wonder if we need a footprint prop that basically says something like "primaryLayer" so that its more clear what layer the user was specifying the footprint for
Member
Author
Even for this case when we have the |
imrishabh18
force-pushed
the
fix-bottom-laer
branch
from
3edfbdd to
b47223a
Compare
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.