Skip to content

Add CreateAutoplacedBreakoutPoints render phase#2349

Merged
MustafaMulla29 merged 5 commits into
mainfrom
pr1/breakout-render-phases-refactor
May 28, 2026
Merged

Add CreateAutoplacedBreakoutPoints render phase#2349
MustafaMulla29 merged 5 commits into
mainfrom
pr1/breakout-render-phases-refactor

Conversation

@MustafaMulla29
Copy link
Copy Markdown
Contributor

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment May 28, 2026 7:07pm

Request Review

Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt seem right, you need to add children in an earlier, is it possible?

…hases-refactor

# Conflicts:
#	tests/breakout/__snapshots__/fanout-soic8-sensor-to-i2c-header-autorouting-srj.snap.svg
@seveibar
Copy link
Copy Markdown
Contributor

This pr cheats the render cycle, we need to fix it!

@MustafaMulla29 MustafaMulla29 changed the title Add breakout render phases and refactor BreakoutPoint for two-phase rendering Add breakout finding phase and refactor BreakoutPoint May 28, 2026
Comment thread lib/components/base-components/Renderable.ts Outdated
Comment thread lib/components/primitive-components/BreakoutPoint.ts Outdated
Comment thread lib/components/primitive-components/BreakoutPoint.ts Outdated
@MustafaMulla29 MustafaMulla29 changed the title Add breakout finding phase and refactor BreakoutPoint Add CreateAutoplacedBreakoutPoints render phase May 28, 2026
@MustafaMulla29 MustafaMulla29 requested a review from seveibar May 28, 2026 19:07
@MustafaMulla29 MustafaMulla29 merged commit 2508e92 into main May 28, 2026
11 checks passed
@MustafaMulla29 MustafaMulla29 deleted the pr1/breakout-render-phases-refactor branch May 28, 2026 20:19
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants