Initial integration of breakout-point-solver#2344
Closed
MustafaMulla29 wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
commented
May 28, 2026
| "PcbBoardAutoSize", | ||
| "PanelLayout", | ||
| "PcbAutoBreakoutPointRender", | ||
| "PcbBreakoutPointRender", |
Contributor
Author
There was a problem hiding this comment.
Kept two phases, instead of duplicating the db insert records for pcb_breakout_point in both Breakout.ts and BreakoutPoint.ts
Contributor
There was a problem hiding this comment.
Rename to something like PcbFindAutoBreqkoutPoints
imrishabh18
reviewed
May 28, 2026
Member
There was a problem hiding this comment.
Can you run the drc check for both before and after? Let us know what is the difference
seveibar
reviewed
May 28, 2026
| private resolvedTarget: ResolvedBreakoutPointTarget | null = null | ||
|
|
||
| setResolvedTarget(target: ResolvedBreakoutPointTarget): void { | ||
| this.resolvedTarget = target |
seveibar
reviewed
May 28, 2026
| } | ||
|
|
||
| function isRerouteReplacementName(value: unknown): boolean { | ||
| return typeof value === "string" && value.includes("_reroute_") |
seveibar
requested changes
May 28, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Make it smaller, we NEED to merge incrementally!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the partial integration of breakout-point-solver, next pr will be to fix overlapping and duplicate traces in the breakout snapshots.