Skip to content

Add PcbCourtyardPill definition and tests#595

Merged
rushabhcodes merged 1 commit into
tscircuit:mainfrom
rushabhcodes:add-pcb-courtyard-pill
May 31, 2026
Merged

Add PcbCourtyardPill definition and tests#595
rushabhcodes merged 1 commit into
tscircuit:mainfrom
rushabhcodes:add-pcb-courtyard-pill

Conversation

@rushabhcodes
Copy link
Copy Markdown
Contributor

This pull request adds support for a new PCB courtyard shape called "Pill" (PcbCourtyardPill) which is alredy present in props repo. It introduces the schema, type definitions, documentation, and tests for this new shape, and integrates it into the existing PCB data model and exports.

New PCB Courtyard Shape: Pill

  • Added a new schema and type definition for PcbCourtyardPill, representing a pill-shaped courtyard on a PCB, including properties such as center, width, height, radius, layer, and optional color (src/pcb/pcb_courtyard_pill.ts).
  • Updated the PCB element type union and exports to include PcbCourtyardPill, ensuring it is recognized as a valid PCB element throughout the codebase (src/pcb/index.ts, src/any_circuit_element.ts). [1] [2] [3] [4]
  • Added documentation for PcbCourtyardPill in the README.md, detailing its properties and usage. [1] [2]

Testing

  • Introduced a unit test for parsing the new pcb_courtyard_pill schema, verifying correct parsing and property values (tests/pcb_courtyard.test.ts). [1] [2]

Copilot AI review requested due to automatic review settings May 31, 2026 14:49
Comment thread tests/pcb_courtyard.test.ts
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rushabhcodes rushabhcodes merged commit 4a555a6 into tscircuit:main May 31, 2026
5 checks passed
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants