Fix gRPC provider to handle typed slice conversion for protobuf marshaling #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes konveyor#973 by adding automatic conversion of typed slices (e.g.,
[]string,[]int) to[]interface{}for protobuf compatibility in the gRPC provider.Problem
The gRPC provider failed when processing provider configurations with typed slices because
structpb.NewStruct()only accepts[]interface{}. This forced callers to manually convert slices, which:Example that previously failed:
Solution
Added reflection-based conversion logic that:
[]interface{}before marshalingChanges
Init()methodGetLocation()methodTesting
structpb.NewStruct()compatibilityPerformance
Benefits