created ingress for kubernetes v1.22 compatible#36
created ingress for kubernetes v1.22 compatible#36prashant637 wants to merge 3 commits intotryretool:mainfrom
Conversation
mukul-c2fo
left a comment
There was a problem hiding this comment.
@prashant637 - Just wondering if this change would let the chart fail on a lower k8s version. What do you think? If so, we can add some conditionals to apply the ingress based on the k8s version it's going to be deployed to.
|
@mukul-c2fo Changes has been done to support the old and new ingress. |
|
@theodormarcu - Could we please get some eyes on this PR as this could be a blocker for us to rollout 1.22. |
|
Hi @prashant637 @mukul-c2fo , sorry for the late reply and thanks for the PR! Looks like this PR is very similar to #38 , except that this one sets the |
|
Hi again! I merged #38 because that one doesn't contain the |
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122