Fix missing usage of postgresql.ssl_enabled in jobs deployment#16
Merged
rhinon merged 2 commits intotryretool:mainfrom May 5, 2021
Merged
Conversation
Adding SSL to deployment_job to support Azure Postgres SSL Requirement
rhinon
approved these changes
May 5, 2021
Contributor
rhinon
left a comment
rhinon
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me.
rhinon
changed the title
asaf400
pushed a commit
to asaf400/retool-helm
that referenced
this pull request
Aug 17, 2023
Merge change - Add startupProbe to backend deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Postgres requires SSL to communicate.
The flag exist in the retool server deployment but not in the backend job deployment.
This causes upgrades to fail as the backend job is unable to complete migrations against postgres.
This fix also includes support for liveness failure threshold so that it can be modified