Draft
Conversation
super().empty() dispatched back to self._empty_general(), looping forever. Call super()._empty_general() directly to hit GroupQuantizedLinearConfig.
Base GroupQuantizedLinearConfig.empty() already dispatches to self._empty_general((), ...) — the override was calling super().empty() which polymorphically re-entered _empty_general and broke the assert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads QLoRA checkpoints from mirai-gpu's RHT (right-hand transposed) format without any monkeypatching.
QLoRALinear.import_weightsunwraps theinner_linearwrapper key present in RHT checkpoints_structure_linear_confighook stripsRHTLinearWrapperConfigfrom the config JSON, resolving the inner type dynamicallyQLoRALinearConfig._empty_generalinfinite recursion (was callingsuper().empty()which re-entered via polymorphic dispatch)QLoRALinearConfig.empty()override — base class already dispatchesempty()→self._empty_general((), ...)Tested against
models/ungodly-lora-r16on gup — model loads and runs.