chore: improve Turborepo configuration#2031
Open
anthonyshew wants to merge 1 commit intotrycompai:mainfrom
Open
chore: improve Turborepo configuration#2031anthonyshew wants to merge 1 commit intotrycompai:mainfrom
anthonyshew wants to merge 1 commit intotrycompai:mainfrom
Conversation
- Use 'turbo run' instead of shorthand in package.json scripts - Change globalDependencies from '**/.env' to '.env' for more specific caching - Add transit task for parallel lint/typecheck with correct cache invalidation - Fix CI workflow script name (type-check:ci -> typecheck:ci) - Move runtime dependencies from root to individual packages - Remove unused dependencies (cheerio, unpdf)
|
@anthonyshew is attempting to deploy a commit to the Comp AI Team on Vercel. A member of the Team first needs to authorize it. |
PR SummaryOptimizes monorepo task orchestration and CI reliability.
Written by Cursor Bugbot for commit 7301322. This will update automatically on new commits. Configure here. |
Author
|
I'm unable to see if the changes to dependencies had a negative effect on builds, but the LLM's analysis in the chat transcript is believable. I reviewed where dependencies get used myself, and it seems those changes are correct, but I could have easily missed something. |
Contributor
|
@anthonyshew thanks for this, overall sounds like good changes, when you get a chance please fix the merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
turbo.json
globalDependenciesfrom**/.envto.env- the wildcard was too broad and caused unnecessary cache invalidationtransittask pattern forlintandtypecheck- enables parallel execution while maintaining correct cache invalidation when dependency source changeslintto usetransitinstead of^lint(lint doesn't need built outputs from dependencies)dependsOn: ["transit"]totypecheckfor proper cross-package type dependency trackingpackage.json (root)
turbo run <task>instead of shorthandturbo <task>(recommended for scripts/CI)dependenciesblock - these belonged in individual packages, not rootcheerio,unpdf,@types/cheerioapps/app/package.json
@upstash/vector(was missing, code imports it).github/workflows/check-types.yml
type-check:citotypecheck:ci(matching actual script in package.json)Testing
After merging, run
bun installto update the lockfile, then verify:bun run buildworksbun run lintworksbun run typecheckworksAI usage