feat:Title: Update documentation for API endpoints and usage examples#72
Conversation
WalkthroughThe changes introduce a new POST endpoint at Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/LangSmith/openapi.yaml (1)
4074-4090: New endpoint added for multipart ingest runsA new endpoint has been added to handle multipart ingest of runs. This is a good addition as it allows for more efficient batch processing of run data. Here are some observations and suggestions:
- The endpoint is correctly tagged under "run" and has a clear description.
- The operation ID
multipart_ingest_runs_api_v1_runs_multipart_postis descriptive and follows the naming convention of other endpoints.- The security requirements (ApiKey, TenantId, BearerAuth) are consistent with other endpoints.
- The response is set to return a JSON object, but the schema is currently unspecified. It would be beneficial to define the response schema for better documentation and client-side type checking.
Consider adding a response schema to provide more information about the expected response format. For example:
responses: '200': description: Successful Response content: application/json: schema: $ref: '#/components/schemas/MultipartIngestRunsResponse'Then, define the
MultipartIngestRunsResponseschema in the components section of the OpenAPI specification.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (5)
src/libs/LangSmith/Generated/JsonSerializerContextTypes.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.IRunClient.MultipartIngestRuns.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.Models.BatchIngestConfig.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.Models.MultipartIngestRunsApiV1RunsMultipartPostResponse.g.csis excluded by!**/generated/**src/libs/LangSmith/Generated/LangSmith.RunClient.MultipartIngestRuns.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/LangSmith/openapi.yaml (2 hunks)
🔇 Additional comments (2)
src/libs/LangSmith/openapi.yaml (2)
10181-10184: New property added to BatchIngestConfigA new property
use_multipart_endpointhas been added to theBatchIngestConfigcomponent. This addition is consistent with the new multipart ingest runs endpoint. Here are some observations:
- The property is of type boolean with a default value of true.
- This allows users to control whether the multipart endpoint should be used for batch ingestion.
- The property is well-placed within the
BatchIngestConfigcomponent.This change provides flexibility for clients to choose between the new multipart endpoint and the existing batch ingest method. It's a good practice to allow for backward compatibility while introducing new features.
Line range hint
1-10184: Summary of changesThe changes to the OpenAPI specification introduce a new feature for multipart ingest of runs while maintaining backward compatibility. Here's an overview of the improvements:
- A new endpoint
/api/v1/runs/multiparthas been added for multipart ingest of runs.- The
BatchIngestConfigcomponent has been updated with ause_multipart_endpointproperty to control the use of this new endpoint.These changes enhance the API's capabilities for handling batch data ingestion more efficiently. The implementation is well-structured and follows the existing patterns in the API specification.
The additions are valuable and have been implemented without breaking existing functionality. To further improve the documentation:
- Consider adding a more detailed description of the multipart ingest process in the endpoint's description.
- Develop and include a response schema for the new endpoint to provide clear expectations for API consumers.
- Update any relevant documentation or client libraries to reflect these new capabilities.
Overall, these changes represent a positive evolution of the LangSmith API.
Summary by CodeRabbit
/api/v1/runs/multipartto enhance multipart processing capabilities.use_multipart_endpointin the BatchIngestConfig, defaulting to true, allowing users to control the use of the new endpoint.