feat: Add subject to LMEval CRD's OCI outputs #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruivieira
added
kind/enhancement
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
@sourcery-ai review |
Contributor
Reviewer's GuideThis PR introduces a new optional “Subject” field to the OCISpec of LMEvalJob, updating the API type, CRD schema, pod‐creation logic to include OCI_SUBJECT when provided, and adds a corresponding unit test. Class diagram for updated OCISpec with Subject fieldclassDiagram
class OCISpec {
string path
string subject
corev1.SecretKeySelector* username
corev1.SecretKeySelector* password
string tag
// ... other fields
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ruivieira - I've reviewed your changes - here's some feedback:
- Add a nil-check for job.Spec.Outputs and OCISpec before accessing Subject to avoid a potential runtime panic when OCISpec is not provided.
- The CRD’s validation pattern for Subject is very generic and only allows uppercase letters; consider tightening it (e.g. matching sha256:[a-f0-9]{64}) or at least allowing lowercase to match typical OCI digest formats.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add a nil-check for job.Spec.Outputs and OCISpec before accessing Subject to avoid a potential runtime panic when OCISpec is not provided.
- The CRD’s validation pattern for Subject is very generic and only allows uppercase letters; consider tightening it (e.g. matching sha256:[a-f0-9]{64}) or at least allowing lowercase to match typical OCI digest formats.
## Individual Comments
### Comment 1
<location> `controllers/lmes/lmevaljob_controller_test.go:4011` </location>
<code_context>
+ t.Run("OCIWithSubject", func(t *testing.T) {
</code_context>
<issue_to_address>
Consider adding negative and edge case tests for OCI_SUBJECT.
Please add tests for cases where the Subject field is omitted, empty, or contains special/invalid characters, to ensure OCI_SUBJECT is handled correctly in all scenarios.
Suggested implementation:
```golang
t.Run("OCIWithSubject", func(t *testing.T) {
job := &lmesv1alpha1.LMEvalJob{
ObjectMeta: v1.ObjectMeta{
Name: "test-oci-subject",
Namespace: "default",
},
Spec: lmesv1alpha1.LMEvalJobSpec{
Model: "test",
TaskList: lmesv1alpha1.TaskList{
TaskNames: []string{"task1"},
},
},
// Add a valid subject
Subject: "valid-subject-123",
}
// ... existing test logic for valid subject ...
})
t.Run("OCIWithSubjectOmitted", func(t *testing.T) {
job := &lmesv1alpha1.LMEvalJob{
ObjectMeta: v1.ObjectMeta{
Name: "test-oci-subject-omitted",
Namespace: "default",
},
Spec: lmesv1alpha1.LMEvalJobSpec{
Model: "test",
TaskList: lmesv1alpha1.TaskList{
TaskNames: []string{"task1"},
},
},
// Subject field omitted
}
// ... test logic to assert OCI_SUBJECT is handled as expected when omitted ...
})
t.Run("OCIWithSubjectEmpty", func(t *testing.T) {
job := &lmesv1alpha1.LMEvalJob{
ObjectMeta: v1.ObjectMeta{
Name: "test-oci-subject-empty",
Namespace: "default",
},
Spec: lmesv1alpha1.LMEvalJobSpec{
Model: "test",
TaskList: lmesv1alpha1.TaskList{
TaskNames: []string{"task1"},
},
},
Subject: "",
}
// ... test logic to assert OCI_SUBJECT is handled as expected when empty ...
})
t.Run("OCIWithSubjectSpecialChars", func(t *testing.T) {
job := &lmesv1alpha1.LMEvalJob{
ObjectMeta: v1.ObjectMeta{
Name: "test-oci-subject-special",
Namespace: "default",
},
Spec: lmesv1alpha1.LMEvalJobSpec{
Model: "test",
TaskList: lmesv1alpha1.TaskList{
TaskNames: []string{"task1"},
},
},
Subject: "!@#$%^&*()_+|~=`{}[]:\";'<>?,./",
}
// ... test logic to assert OCI_SUBJECT is handled as expected with special/invalid characters ...
})
```
You will need to fill in the test logic for each new test case to assert the correct handling of the `OCI_SUBJECT` environment variable (e.g., check if it is set, unset, or sanitized as appropriate for your application). If there is a helper function or assertion pattern used in the original "OCIWithSubject" test, reuse it for consistency.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tarilabs
reviewed
Jul 30, 2025
tarilabs
left a comment
tarilabs
left a comment
There was a problem hiding this comment.
thanks a lot @ruivieira ! One comment below:
otherwise
/lgtm
|
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 📦 Guardrails orchestrator image: 🗂️ CI manifests |
ruivieira
merged commit 33463bc
into
trustyai-explainability:dev/oci
3 of 5 checks passed
tarilabs
pushed a commit
to tarilabs/trustyai-service-operator
that referenced
this pull request
Sep 17, 2025
…y#530) * feat: Add subject to LMEval CRD's OCI outputs * chore: Add more test cases
tarilabs
pushed a commit
to tarilabs/trustyai-service-operator
that referenced
this pull request
Nov 18, 2025
…y#530) * feat: Add subject to LMEval CRD's OCI outputs * chore: Add more test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add support for an OCI subject in LMEvalJob outputs by extending the OCISpec type, updating the CRD schema, injecting the OCI_SUBJECT env var in pods, and adding a corresponding unit test
New Features:
Documentation:
Tests: