Skip to content

Conversation

@gupnik
Copy link
Collaborator

@gupnik gupnik commented Aug 20, 2025

Description

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

Binary size comparison

➡️ aarch64-apple-ios:

- 14.96 MB
+ 14.94 MB 	 -17 KB

➡️ aarch64-apple-ios-sim:

- 14.96 MB
+ 14.94 MB 	 -17 KB

➡️ aarch64-linux-android:

- 19.92 MB
+ 19.89 MB 	 -29 KB

➡️ armv7-linux-androideabi:

- 16.64 MB
+ 16.62 MB 	 -24 KB

➡️ wasm32-unknown-emscripten:

- 14.33 MB
+ 14.31 MB 	 -14 KB

@gupnik gupnik changed the title Normalisation and derivation fixes Normalisation/Derivation fixes and remove ed25519-bip32 dependency (use cryptoxide directly) Aug 25, 2025
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gupnik gupnik merged commit 0f80cb6 into dev Aug 25, 2025
15 checks passed
@gupnik gupnik deleted the gupnik/fixes branch August 25, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants