Remove trezor crypto #4404
Merged
Remove trezor crypto #4404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove-trezor-crypto # Conflicts: # rust/tw_crypto/src/crypto_hd_node/ecdsa/nist256p1/mod.rs # rust/tw_crypto/src/crypto_hd_node/ecdsa/secp256k1/mod.rs # rust/tw_crypto/src/crypto_hd_node/ed25519/cardano/mod.rs # rust/tw_crypto/src/crypto_hd_node/extended_key/bip32_private_key.rs # rust/tw_crypto/src/crypto_hd_node/extended_key/extended_private_key.rs # rust/tw_crypto/src/crypto_hd_node/extended_key/extended_public_key.rs # rust/tw_crypto/src/crypto_hd_node/extended_key/hd_version.rs # rust/tw_crypto/src/crypto_hd_node/hd_node.rs # rust/tw_crypto/src/crypto_hd_node/zilliqa_schnorr/mod.rs # rust/tw_crypto/src/ffi/crypto_hd_node.rs # rust/tw_crypto/src/ffi/crypto_hd_node_public.rs # rust/tw_crypto/tests/extended_private_key.rs # rust/tw_crypto/tests/hd_node_ffi.rs # rust/tw_crypto/tests/hd_node_public_ffi.rs # rust/tw_hash/src/hasher.rs # rust/tw_keypair/src/ecdsa/nist256p1/private.rs # rust/tw_keypair/src/ecdsa/nist256p1/public.rs # rust/tw_keypair/src/ecdsa/secp256k1/private.rs # rust/tw_keypair/src/ecdsa/secp256k1/public.rs # rust/tw_keypair/src/ed25519/modifications/cardano/extended_private.rs # rust/tw_keypair/src/ed25519/modifications/waves/private.rs # rust/tw_keypair/src/ed25519/private.rs # rust/tw_keypair/src/traits.rs # rust/tw_keypair/src/zilliqa_schnorr/private.rs # rust/tw_keypair/src/zilliqa_schnorr/public.rs # src/HDWallet.cpp
Binary size comparison➡️ aarch64-apple-ios: - 14.98 MB
+ 14.99 MB +9 KB➡️ aarch64-apple-ios-sim: - 14.98 MB
+ 14.99 MB +9 KB➡️ aarch64-linux-android: - 20.04 MB
+ 20.06 MB +15 KB➡️ armv7-linux-androideabi: - 16.68 MB
+ 16.69 MB +9 KB➡️ wasm32-unknown-emscripten: - 14.34 MB
+ 14.35 MB +9 KB |
Collaborator
satoshiotomakan
left a comment
satoshiotomakan
left a comment
There was a problem hiding this comment.
Good job! Let's make a couple of minor improvements before merging the PR!
|
|
||
| #[tw_ffi(ty = static_function, class = TWCurve25519, name = PubkeyToEd25519)] | ||
| #[no_mangle] | ||
| pub unsafe extern "C" fn tw_curve25519_pubkey_to_ed25519( |
Collaborator
There was a problem hiding this comment.
It looks like an internal function. For the future, let's add them manually, or extend tw_ffi to not expose such an FFI to Kotlin, Swift etc
| /// \param is_secp256k1 whether the signature is a secp256k1 signature. | ||
| /// | ||
| /// \return DER-encoded signature. | ||
| #[tw_ffi(ty = static_function, class = TWECDSA, name = SigToDER)] |
Collaborator
There was a problem hiding this comment.
TWECDSA looks like an internal as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes trezor crypto and migrates remaining API calls to Rust via FFI.
How to test
Run tests
Types of changes
Refactor
Checklist
If you're adding a new blockchain