Replaces bip39.c with Rust implementation via FFI
#4384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary size comparison➡️ aarch64-apple-ios: - 14.03 MB
+ 14.51 MB +490 KB➡️ aarch64-apple-ios-sim: - 14.04 MB
+ 14.51 MB +491 KB➡️ aarch64-linux-android: - 18.52 MB
+ 19.37 MB +868 KB➡️ armv7-linux-androideabi: - 15.50 MB
+ 16.05 MB +567 KB➡️ wasm32-unknown-emscripten: - 13.20 MB
+ 13.72 MB +535 KB |
satoshiotomakan
requested changes
Apr 30, 2025
satoshiotomakan
approved these changes
Apr 30, 2025
Collaborator
satoshiotomakan
left a comment
satoshiotomakan
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates mnemonic creation and management to Rust.
How to test
Added expansive tests to cover test vectors from trezor crypto and existing C++ tests.
Types of changes
Refactor
Checklist
If you're adding a new blockchain