[ETH]: Makes factory and paymaster optional while serialising UserOpV07 #4345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary size comparison➡️ aarch64-apple-ios: - 13.92 MB
+ 13.93 MB +1 KB➡️ aarch64-apple-ios-sim: - 13.93 MB
+ 13.93 MB +1 KB➡️ aarch64-linux-android: 18.35 MB ➡️ armv7-linux-androideabi: 15.36 MB ➡️ wasm32-unknown-emscripten: - 13.06 MB
+ 13.06 MB +1 KB |
satoshiotomakan
approved these changes
Apr 1, 2025
10gic
reviewed
Apr 1, 2025
| nonce: String, | ||
| factory: String, | ||
| factory: Option<String>, | ||
| factory_data: String, |
Contributor
There was a problem hiding this comment.
Intuitively, if the factory is optional, then the factory_data should also be optional. 😃
satoshiotomakan
added a commit
that referenced
this pull request
Apr 2, 2025
* feat(eip7702): Add Biz Smart Contract Account Type (#4319) * fix(eip7702): Add `UserOperationMode` * Add `erc4337.biz_account.abi.json` ABI * fix(eip7702): Add `test_barz_transfer_erc7702_eoa` test * fix(eip7702): Fix `Biz.execute4337Ops()` * fix(eip7702): Minor changes * fix(eip7702): Rename `UserOperationMode` to `SCAccountType` * fix: tron message sign (#4326) * Adds ability to specify the curve while constructing Private Key (#4324) * Adds ability to specify the curve while constructing Private Key * Adds signing functions without a curve * Migrates to new API * Use TWCoinTypeCurve * Adds Curve * feat(eip7702): Add `SetCode` transaction type (#4336) * fix(eip7702): Add `SetCode` transaction type * fix(eip7702): Add `Biz.executeBatch` function call * Add `AuthorizationSigner` * fix(eip7702): Fix Authorization list RLP encoding * fix(eip7702): Add `Biz.execute` and `Biz.executeBatch` tests * fix(eip7702): Add android test * [CI] Trigger CI * feat(biz): Adjust `Barz.getEncodedHash` according to the latest changes in Biz contract (#4342) * fix(biz): Adjust `Barz.getEncodedHash` according to the latest Biz changes * fix(biz): Adjust Android test * chore(dependencies): Update `gtest` to 1.16.0 (#4343) * [ETH]: Makes factory and paymaster optional while serialising UserOpV07 (#4345) * Uses updated API --------- Co-authored-by: Sergei Boiko <[email protected]> Co-authored-by: Yeferson Licet <[email protected]>
satoshiotomakan
added a commit
that referenced
this pull request
Apr 9, 2025
* feat(eip7702): Add Biz Smart Contract Account Type (#4319) * fix(eip7702): Add `UserOperationMode` * Add `erc4337.biz_account.abi.json` ABI * fix(eip7702): Add `test_barz_transfer_erc7702_eoa` test * fix(eip7702): Fix `Biz.execute4337Ops()` * fix(eip7702): Minor changes * fix(eip7702): Rename `UserOperationMode` to `SCAccountType` * fix: tron message sign (#4326) * Adds ability to specify the curve while constructing Private Key (#4324) * Adds ability to specify the curve while constructing Private Key * Adds signing functions without a curve * Migrates to new API * Use TWCoinTypeCurve * Adds Curve * feat(eip7702): Add `SetCode` transaction type (#4336) * fix(eip7702): Add `SetCode` transaction type * fix(eip7702): Add `Biz.executeBatch` function call * Add `AuthorizationSigner` * fix(eip7702): Fix Authorization list RLP encoding * fix(eip7702): Add `Biz.execute` and `Biz.executeBatch` tests * fix(eip7702): Add android test * [CI] Trigger CI * feat(biz): Adjust `Barz.getEncodedHash` according to the latest changes in Biz contract (#4342) * fix(biz): Adjust `Barz.getEncodedHash` according to the latest Biz changes * fix(biz): Adjust Android test * chore(dependencies): Update `gtest` to 1.16.0 (#4343) * [ETH]: Makes factory and paymaster optional while serialising UserOpV07 (#4345) * feat(biz): Allow to call `Biz.execute` when EOA is delegated already (#4351) * fix(biz): Allow to call `Biz.execute` when EOA is delegated already * feature(biz): Adopt C++ tests * feat(biz): Add and fix android tests * feat(biz): Fix ios tests * chore(aa): Rename `Execute` and `Batch` to `AAExecute` and `AABatch` correspondingly * chore(scw): Rename `AABatch` and `AAExecute` to `SCWalletBatch` and `SCWalletExecute` * chore(uov7): Serialize UserOperation numbers as hex 0x prefixed (#4353) --------- Co-authored-by: Sergei Boiko <[email protected]> Co-authored-by: Yeferson Licet <[email protected]>
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 15, 2025
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes factory and paymaster optional while serialising UserOpV07
How to test
Existing tests continue to work
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
If you're adding a new blockchain