Skip to content

Conversation

@akokhanovskyi
Copy link
Contributor

@akokhanovskyi akokhanovskyi commented Nov 2, 2020

This is WIP, please do not merge yet; comments are welcome!

@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #69 into master will decrease coverage by 1.85%.
The diff coverage is 80.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   89.47%   87.61%   -1.86%     
==========================================
  Files           6        7       +1     
  Lines         304      323      +19     
==========================================
+ Hits          272      283      +11     
- Misses         17       26       +9     
+ Partials       15       14       -1     
Impacted Files Coverage Δ
graph_connect.go 89.85% <78.94%> (-1.45%) ⬇️
address.go 80.95% <80.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d1d63...f8a9e16. Read the comment docs.

const scalingFactor = 2

if port.Cap() <= key {
port.SetCap(2 * key)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is guaranteed to panic. To "extend" the underlying array, you have to reallocate the slice and copy the data.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.34783% with 18 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (b48b2ee) to head (265c5fa).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
graph_connect.go 77.50% 6 Missing and 3 partials ⚠️
graph_iip.go 33.33% 2 Missing and 2 partials ⚠️
graph_ports.go 50.00% 2 Missing and 2 partials ⚠️
graph.go 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   89.43%   88.30%   -1.14%     
==========================================
  Files           6        7       +1     
  Lines         303      342      +39     
==========================================
+ Hits          271      302      +31     
- Misses         17       22       +5     
- Partials       15       18       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants