Skip to content

Fix wrong line number in private key detector (#4485) #4486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2025
Merged

Fix wrong line number in private key detector (#4485) #4486

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95d1c2e
Fix wrong line number in private key detector (#4485)
kmgv Oct 4, 2025
559bf82
Merge branch 'main' into bugfix/private-key-loc
kashifkhan0771 Oct 8, 2025
7f9bd2a
Merge branch 'main' into bugfix/private-key-loc
shahzadhaider1 Oct 9, 2025
1bcea39
Fix wrong line number in private key detector - use primary primarySe…
kmgv Oct 11, 2025
9c1b1aa
Merge branch 'main' into bugfix/private-key-loc
kashifkhan0771 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/detectors/privatekey/privatekey.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result
ExtraData: make(map[string]string),
}

// set not normalized match as primary secret value so it is used to calculate line of code
s1.SetPrimarySecretValue(match)

var passphrase string
parsedKey, err := ssh.ParseRawPrivateKey([]byte(token))
if err != nil && strings.Contains(err.Error(), "private key is passphrase protected") {
Expand Down