Skip to content

Proto update to support scanning confluence comments #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2025
Merged

Proto update to support scanning confluence comments #4484

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2af04a7
change in protos to support scanning confluence comments
mustansir14 Oct 3, 2025
5cc120e
rename comment -> commentId
mustansir14 Oct 3, 2025
670985c
Merge branch 'main' into INS-28-Scan-Confluence-comments
shahzadhaider1 Oct 7, 2025
488ba10
use snakecase for comment_id
mustansir14 Oct 7, 2025
aa406ef
Merge branch 'INS-28-Scan-Confluence-comments' of mustansir:mustansir…
mustansir14 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,030 changes: 520 additions & 510 deletions pkg/pb/source_metadatapb/source_metadata.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions pkg/pb/source_metadatapb/source_metadata.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1,353 changes: 682 additions & 671 deletions pkg/pb/sourcespb/sources.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions pkg/pb/sourcespb/sources.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/source_metadata.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ message Confluence {
string location = 7;
string file = 8;
string user = 9;
string comment = 10;
Copy link
Contributor

@rosecodym rosecodym Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike all the other fields, I can't form a good guess about what's stored in this just by reading its name. Is it a comment ID or something?

Copy link
Contributor Author

@mustansir14 mustansir14 Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the comment ID. I tried to make it consistent with other fields, but you're right, it should be clearer. I'll make the change.

}

message Docker {
Expand Down
1 change: 1 addition & 0 deletions proto/sources.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ message Confluence {
repeated string ignore_spaces = 8;
bool include_attachments = 9;
bool skip_history = 10;
bool include_comments = 11;
}

message Docker {
Expand Down