feat: create delete mode and refactor renovate.json#171
Conversation
🦋 Changeset detectedLatest commit: 24e5635 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded@trueberryless has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 34 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughRenovate configuration is migrated from renovate.json5 to renovate.json. A new template file is added, the old one is removed, and repos.json mappings are updated to point to the new file with delete directives for the old. sync_templates.sh gains a special delete operation. Two changeset notes document these updates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
sync_templates.sh (2)
257-261: Use git add -A so deletions are staged; otherwise delete operations won’t be committed
git add .won’t reliably stage file deletions; usegit add -Aorgit add -u. This is critical for your new delete mode to result in an actual commit.-git add . +git add -A
33-54: Nit: avoid fetching/validating src for non-content ops in the futureWith the early “delete” short‑circuit in place (see above), we can skip URL downloads and local file existence checks entirely for such ops. This saves a network roundtrip and avoids false negatives when the source path doesn’t exist.
repos.json (1)
2278-2283: Copy/paste bug: repositoryName is incorrect for “marketing”
repositoryNameunder the marketing block is set to “truzzles”. This will render incorrect text in templates/workflows and could break deployments.- "props": { - "repositoryName": "truzzles" - } + "props": { + "repositoryName": "marketing" + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
.changeset/curly-zoos-exist.md(1 hunks).changeset/tiny-insects-dream.md(1 hunks)repos.json(28 hunks)sync_templates.sh(4 hunks)template-files/.github/renovate.json(1 hunks)template-files/.github/renovate.json5(0 hunks)
💤 Files with no reviewable changes (1)
- template-files/.github/renovate.json5
🧰 Additional context used
🪛 LanguageTool
.changeset/tiny-insects-dream.md
[grammar] ~5-~5: Use prepositions correctly
Context: ...iles": minor --- Rename renovate.json5 into renovate.json and adapt it to include n...
(QB_NEW_EN_OTHER_ERROR_IDS_7)
[grammar] ~5-~5: There might be a mistake here.
Context: ...nclude npm updates (major and non-major)
(QB_NEW_EN_OTHER)
.changeset/curly-zoos-exist.md
[grammar] ~5-~5: There might be a mistake here.
Context: ...cial file treatment: delete (path still neede nonetheless, altough useless)
(QB_NEW_EN_OTHER)
[grammar] ~5-~5: Ensure spelling is correct
Context: ...: delete (path still neede nonetheless, altough useless)
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~5-~5: There might be a mistake here.
Context: ...till neede nonetheless, altough useless)
(QB_NEW_EN_OTHER)
🪛 markdownlint-cli2 (0.17.2)
.changeset/tiny-insects-dream.md
5-5: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
.changeset/curly-zoos-exist.md
5-5: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🔇 Additional comments (6)
.changeset/tiny-insects-dream.md (1)
5-5: OK to ignore MD041 for .changeset filesmarkdownlint’s “first-line heading” rule (MD041) isn’t typically applicable to Changesets entries. No action needed unless your pipeline enforces MD041 on this folder. If it does, consider excluding
.changeset/**in your linter config..changeset/curly-zoos-exist.md (1)
5-5: MD041 note (informational)Same as the other changeset: safe to ignore the first-line heading warning unless you enforce it for
.changeset/**.template-files/.github/renovate.json (2)
33-37: pnpm packageManager rule looks goodDisabling updates to the packageManager field via a targeted rule is correct. Renovate recognizes
matchDepTypes: ["packageManager"]on npm manager.
3-10: Replace invalid Renovate helper presetThe preset
"helpers:pinGitHubActionDigestsToSemver"does not exist in Renovate’s catalog. To pin GitHub Action digests while respecting semver-style tags, use the built-in helper:• File:
template-files/.github/renovate.json
• Update theextendsarray entry:"extends": [ ":disableDependencyDashboard", ":semanticPrefixFixDepsChoreOthers", ":ignoreModulesAndTests", "workarounds:all", - "helpers:pinGitHubActionDigestsToSemver", + "helpers:pinGitHubActionDigests", "docker:disable" ],This change ensures Renovate recognizes the helper and correctly pins action digests.
Likely an incorrect or invalid review comment.
repos.json (2)
30-36: Renovate migration mapping looks correctAdding
.github/renovate.jsonand a separatespecial: "delete"mapping for.github/renovate.json5is the right pattern. This repeats consistently across repos.
30-36: Sanity check passed: all.github/renovate.json5mappings are marked for deletion as expected.
No further action required.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 participant
Summary by CodeRabbit