BUG: XLWorksheet::merges()

[isajkin]

If there are no merged cells, the function creates an empty node and EXCEL does not read such a file.

[isajkin]

I think you need to make a bool function XLWorksheet::hasMerges()

[aral-matrix]

Thanks for the report - when constructing an empty node, I believe only the "count = 0" was missing. If you could please check the commit 75f9be4 and let me know if that fixes it?

[isajkin]

Unfortunately, your fix didn't help. Excel still doesn't understand "count='0'"

[aral-matrix]

https://c-rex.net/samples/ooxml/e1/Part4/OOXML_P4_DOCX_mergeCells_topic_ID0EFE44.html

Indeed - the specification says "minOccurs" is 1, the count field is even optional. Microsoft is really the worst... I'll fix it later today or so.

[aral-matrix]

Mhh... this is more complicated unfortunately - your solution doesn't help anyways when the user creates a merge, then deletes it ending up at 0 again, so I have to delete the mergeCells tag from the worksheet upon save. However, if I do this in the current implementation, it would invalidate an already initialized XLMergeCells object.
I will probably do a dirty hack that only affects the saved file, but not the in-memory implementation. Not today though.

[aral-matrix]

Fixed in 13b1461 (development-aral branch) - if you could test and provide some feedback that would be appreciated.

[isajkin]

I checked the functions merges().findMergeByCell(,,,). An empty node is not written to the file.

[aral-matrix]

Okay, I will then close this as resolved when I merge the patch into the master branch. Thanks for checking!

[aral-matrix]

merged into master today