Bug in inline std::ostream& operator<<(std::ostream& os, const XLCellValue& value) ?

[ofenloch]

This test fails

        XLDocument doc;
        doc.create(fileName);

        auto wks = doc.workbook().worksheet("Sheet1");
        wks.cell("A1").value() = "Hello OpenXLSX!";

        std::stringstream sstream2;
        sstream2 << wks.cell("A1").value();
        // This fails:
        REQUIRE(sstream2.str() == "Hello OpenXLSX!");

Is this a bug or am I doing something wrong?

[ofenloch]

However, casting wks.cell("A1").value() to XLValue makes it work

        // This works:
        std::stringstream sstream2;
        sstream2 << (XLCellValue)wks.cell("A1").value();
        REQUIRE(sstream2.str() == "Hello OpenXLSX!");

        // This fails:
        std::stringstream sstream3;
        sstream3 << wks.cell("A1").value();
        REQUIRE(sstream3.str() == "Hello OpenXLSX!");

[aral-matrix]

Is this a bug or am I doing something wrong?

Hi @ofenloch - you actually did find a bug: The XLCellValue overload for operator<< with a string stream was using XLCellValue::get with a reference string type (std::string_view), however this XLCellValue was a temporary object and by the time the return value was to be assigned to the string stream, it was invalid.

I have implemented a fix for the operator overload and a workaround for accessing XLCellValue::get<>() with string references in the development-aral branch, patch 4ed9c97.

I apologize for the late fix, I finally got around to work on the backlog of issues. Will close this when I merge the functionality into master.

[aral-matrix]

merged the patch into master today

[ofenloch]

Thanks for the update, @aral-matrix.