Skip to content

Conversation

@whatdhack
Copy link

Adding label to print out table.

@whatdhack whatdhack requested a review from ptillet as a code owner October 29, 2025 16:39
@Jokeren
Copy link
Contributor

Jokeren commented Oct 29, 2025

TBH I don't think this is very necessary...

@whatdhack
Copy link
Author

Please see issue - #8545 .

@Jokeren
Copy link
Contributor

Jokeren commented Oct 29, 2025

Isn't the ylabel already TFLOPS?

@whatdhack
Copy link
Author

whatdhack commented Oct 29, 2025

The printed table does not have any unit label , so it could be interpreted as ms and the consequent opposite conclusion. Please see issue - #8545 .

@peterbell10
Copy link
Contributor

Can you change the perf_report code to add labels to all tables, not special case the matmul tutorial.

@whatdhack
Copy link
Author

whatdhack commented Oct 29, 2025

Good idea. Let me take a look.

@Jokeren
Copy link
Contributor

Jokeren commented Oct 29, 2025

Can you change the perf_report code to add labels to all tables, not special case the matmul tutorial.

Sure, that would be useful

@whatdhack whatdhack changed the title Adding label TFLOPS to table. Adding ylabel to command line outputs. Nov 2, 2025
peterbell10 added a commit that referenced this pull request Nov 4, 2025
Closes #8588

Example:
```
vector-add-performance:
           size  Triton (GB/s)  Torch (GB/s)
0        4096.0       8.827586      8.777143
1        8192.0      16.695652     17.454545
2       16384.0      34.711865     34.516854
```
peterbell10 added a commit that referenced this pull request Nov 4, 2025
Closes #8588

Example:
```
vector-add-performance:
           size  Triton (GB/s)  Torch (GB/s)
0        4096.0       8.827586      8.777143
1        8192.0      16.695652     17.454545
2       16384.0      34.711865     34.516854
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants